flup 1.0.1 released

Tuesday, July 22. 2008

A very minor update to flup. If you aren't having any problems now, then there's probably no need to upgrade.

This update concerns certain web servers & configurations that don't correctly supply PATH_INFO and/or QUERY_STRING to flup. When missing these environment entries, the flup servers will now attempt to deduce PATH_INFO and/or QUERY_STRING from REQUEST_URI (if it is present) before defaulting to the empty string (as it did before).

Thanks to Richard Davies for the patch.

Posted by Allan Saddi in flup at 11:50 | Comments (8) | Trackbacks (0)

Trackbacks

Trackback specific URI for this entry

No Trackbacks

Comments

Display comments as (Linear | Threaded)

First I'd like to say that flup is awesome! However, I'm having a little bit of trouble...

I can't seem to get flup.server.fcgi to work with a unix domain socket. After investigating the problem a bit, i found this file:

flup/server/paste_factory.py

which (for me, as a turbogears user) was actually controlling the creation of flup.server.fcgi I noticed that no matter what, bindAddress is set to a tuple (therefore eliminating the ability to run a server on a unix domain socket)

The simple fix that I employed was to add a conditional to line 6

if not 'bindAddress' in local_config:

which would make it so that the tuple is only created if bindAddress is empty.

Alternatively, you could provide a config value "socket"

and do something like

if 'socket' in local_config:
local_config['bindAddress'] = local_config['socket']
del local_config['socket'] #no sense storing it twice, plus socket could cause a name collision
else:
local_conf['bindAddress'] = (host, int(port))

**** I prefer this second method as it provides a more consistent configuration value to the user

Also sorry, I would have posted a trac ticket, but I don't see a way to sign up to do so...

Anyways great work! There's my two cents.

cheers
-Dan

#1 Dan Roberts on 2008-07-23 20:37 (Reply)

Sorry, the comment system ate my leading spaces, but i'm pretty sure the meaning is obvious

#1.1 Dan Roberts on 2008-07-23 21:45 (Reply)

Thanks for the suggestion. It looks like the original flup factories (bundled with Paste) supported the 'socket' option. I didn't realize that feature was lost.

I went ahead and committed your change, but I have no idea when I'll be making the next release (I knew I was a bit hasty with yesterday's release). But the latest is always available at http://hg.saddi.com/flup-server/

And as for trac, the username/password is trac/trac1234. I should make it more prominent.

Thanks again.

#1.2 Allan Saddi (Homepage) on 2008-07-23 22:57 (Reply)

Oh, I didn't realize there was a factory available with paste... Well at least there's now a version in trunk that works

Thanks for the speedy response

#1.2.1 Dan Roberts on 2008-07-24 02:28 (Reply)

flup seems to depend on setuptools at http://cheeseshop.python.org/packages/2.6/s/setuptools/setuptools-0.6c6-py2.6.egg

Now it is at
http://cheeseshop.python.org/packages/2.6/s/setuptools/setuptools-0.6c9-py2.6.egg

the c6 version doesn't exist, the c9 version is the only one there. Renaming the c9 version to c6 and placing it in the flup directory seems to work, but could confuse or delay people.

#2 v+python on 2008-11-30 23:54 (Reply)

Another problem is that PasteScript is deprecating the use of this style of factory:

use = egg:PasteScript#flup_fcgi_thread

However, if one does this:

use = egg:flup#fcgi
(or egg:flup#fcgi_thread, they are the same)

PasteScript#flup_fcgi_thread accepts any of

host, port, and socket
(and a few others that aren't relevant here).

If you don't specify them, then bindAddress=None is used.
There is no way to replicate bindAddress=None (that I can see) using flup#fcgi, a problem for any app that relies on that behavior.

Can you think of a reasonable fix?
Also, when might the next flup release be?

#3 Jon on 2009-05-18 14:56 (Reply)

I don't really remember the rationale for deprecating the factories in Paste. Though I guess it makes more sense if they were packaged with flup.

A problem is that flup's paste_factory is a one-size-fits-all deal. (And it doesn't really fit all...)

I guess I might look into pulling Paste's factories into flup. This may cause some issues, mainly with regards to defaults.

#3.1 Allan Saddi (Homepage) on 2009-05-18 15:35 (Reply)

I just saw in mercurial that you have done this.
Fantastic!

I'll try to give this a test soon.

I'm really looking forward to the next release!

#3.1.1 Jon Nelson on 2009-05-21 11:38 (Reply)

Add Comment

Name
Email
Homepage
In reply to
Comment	Enclosing asterisks marks text as bold (word), underscore are made via _word_. Standard emoticons like :-) and ;-) are converted to images. To prevent automated Bots from commentspamming, please enter the string you see in the image below in the appropriate input box. Your comment will only be submitted if the strings match. Please ensure that your browser supports and accepts cookies, or your comment cannot be verified correctly. Enter the string from the spam-prevention image above:
	Remember Information? Subscribe to this entry